Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing syntax errors in multizone simple office semantic model. #709

Open
wants to merge 14 commits into
base: issue591_addSemanticTags
Choose a base branch
from

Conversation

lazlop
Copy link

@lazlop lazlop commented Nov 25, 2024

There are some syntax errors in the semantic model it would be good to fix while creating it. I fixed all the issues, so we can see examples of what needs to be fixed in the track changes.

Syntax corrections needed are roughly:

  • No quotes in node URIs (things after the colon)

  • we can replace things in the literal namespace with normal literals now! (literal:text to "text")

  • Make sure no periods are in the wrong places.

  • Can't use '/' character in URIs. Use qudt for units which has convention X-PER-Y or put in quotes.

  • Period only at the end of all triples, if there will be another predicate and object than have to use semicolon.

  • Make sure angle brackets don't get through like ref:name literal:<cdl_instance_name>_y

    • Only happened two places
  • external references are generally for where a data source is external to the graph. References for zones and equipment aren't really external, we should discuss if we want to include them.

  • has external reference for equipment/zones is incorrect, not actually referencing the external reference but referencing itself.

           e.g. "bldg:flo_Cor a brick:Zone;
          ref:hasExternalReference bldg:flo_Cor."
  • should flo_Eas be just Eas (and same for other zones)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants