From 1fa4f6f148667f3a3de250f08b026c3946bdd5e1 Mon Sep 17 00:00:00 2001 From: Robert Parker Date: Fri, 8 Mar 2019 12:59:54 +0000 Subject: [PATCH] fix gosec failures --- cmd/runmqdevserver/template.go | 1 + cmd/runmqserver/main.go | 5 ++++- cmd/runmqserver/process.go | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/cmd/runmqdevserver/template.go b/cmd/runmqdevserver/template.go index 2600c513..de683936 100644 --- a/cmd/runmqdevserver/template.go +++ b/cmd/runmqdevserver/template.go @@ -36,6 +36,7 @@ func processTemplateFile(templateFile, destFile string, data interface{}) error _, err = os.Stat(dir) if err != nil { if os.IsNotExist(err) { + // #nosec G301 err = os.MkdirAll(dir, 0770) if err != nil { log.Error(err) diff --git a/cmd/runmqserver/main.go b/cmd/runmqserver/main.go index 2b46a9ea..2814e272 100644 --- a/cmd/runmqserver/main.go +++ b/cmd/runmqserver/main.go @@ -45,7 +45,10 @@ func doMain() error { // Check whether they only want debug info if *infoFlag { logVersionInfo() - logContainerDetails() + err = logContainerDetails() + if err != nil { + log.Printf("Error displaying container details: %v", err) + } return nil } diff --git a/cmd/runmqserver/process.go b/cmd/runmqserver/process.go index 03d6c566..dafd9b6c 100644 --- a/cmd/runmqserver/process.go +++ b/cmd/runmqserver/process.go @@ -42,6 +42,7 @@ func verifySingleProcess() error { // Verifies that there is only one instance running of the given program name. func verifyOnlyOne(programName string) (int, error) { + // #nosec G104 out, _, _ := command.Run("ps", "-e", "--format", "cmd") //if this goes wrong then assume we are the only one numOfProg := strings.Count(out, programName)