fix(field_index): get field index w.r.t. pre-join table schemata #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoinChains provide the schema of the joined table (which is great for Ibis) but for substrait we need the Field index computed with respect to the original table schemata. In practice, this means rolling through the tables in a JoinChain and computing the field index _without_ removing the join key Given Table 1 a: int b: int Table 2 a: int c: int JoinChain[r0] JoinLink[inner, r1] r0.a == r1.a values: a: r0.a b: r0.b c: r1.c If we ask for the field index of `c`, the JoinChain schema will give us an index of `2`, but it should be `3` because 0: table 1 a 1: table 1 b 2: table 2 a 3: table 2 c So now we pull out the correct JoinReference object and use that to index into the tables in the JoinChain and offset by the length of the schema of those preceding tables.
gforsyth
force-pushed
the
fix_join_chain_field_offsets
branch
from
bdf1acf
to
e10b9b8
Compare
cpcloud
requested changes
Jul 23, 2024
| @@ -732,7 +732,7 @@ | |||
| "selection": { | |||
| "directReference": { | |||
| "structField": { | |||
| "field": 1 | |||
| "field": 45 | |||
There was a problem hiding this comment.
A 45x improvement in accuracy!!
Co-authored-by: Phillip Cloud <[email protected]>
gforsyth
force-pushed
the
fix_join_chain_field_offsets
branch
from
47df9f7
to
5418744
Compare
gforsyth
pushed a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JoinChains provide the schema of the joined table (which is great for Ibis)
but for substrait we need the Field index computed with respect to
the original table schemata. In practice, this means rolling through
the tables in a JoinChain and computing the field index without
removing the join key
Given
If we ask for the field index of
c, the JoinChain schema will giveus an index of
2, but it should be3becauseSo now we pull out the correct JoinReference object and use that to
index into the tables in the JoinChain and offset by the length of the
schema of those preceding tables.
Resolves #1072