Skip to content

Commit

Permalink
refactor: drop support for Python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
gforsyth committed Jul 6, 2023
1 parent 2ff03de commit 023351b
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 18 deletions.
21 changes: 13 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
os:
- ubuntu-latest
python-version:
- "38"
- "39"
- "310"
- "311"
Expand Down Expand Up @@ -90,16 +89,18 @@ jobs:
os:
- ubuntu-latest
python-version:
- "3.8"
- "3.10"
- "3.9"
- "3.11"
ibis-version:
- "3.2"
- "4.1"
- "5.1"
include:
- os: windows-latest
python-version: "3.11"
ibis-version: "5.1"
- os: ubuntu-latest
python-version: "3.10"
ibis-version: "4.1"
ibis-version: "3.2"


steps:
Expand Down Expand Up @@ -130,11 +131,15 @@ jobs:
os:
- ubuntu-latest
python-version:
- "3.8"
- "3.10"
- "3.9"
- "3.11"
ibis-version:
- "3.2"
- "4.1"
- "5.1"
include:
- os: ubuntu-latest
python-version: "3.10"
ibis-version: "3.2"

steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 1 addition & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
in
rec {
packages = {
inherit (pkgs) ibisSubstrait38 ibisSubstrait39 ibisSubstrait310 ibisSubstrait311;
inherit (pkgs) ibisSubstrait39 ibisSubstrait310 ibisSubstrait311;

default = pkgs.ibisSubstrait311;
};
Expand All @@ -90,7 +90,6 @@
nixpkgs = pkgs;

devShells = rec {
ibisSubstrait38 = mkDevShell pkgs.ibisSubstraitDevEnv38;
ibisSubstrait39 = mkDevShell pkgs.ibisSubstraitDevEnv39;
ibisSubstrait310 = mkDevShell pkgs.ibisSubstraitDevEnv310;
ibisSubstrait311 = mkDevShell pkgs.ibisSubstraitDevEnv311;
Expand Down
2 changes: 0 additions & 2 deletions nix/overlay.nix
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,10 @@ let
final.callPackage drv { inherit python; };
in
{
ibisSubstraitDevEnv38 = mkPoetryEnv final.python38;
ibisSubstraitDevEnv39 = mkPoetryEnv final.python39;
ibisSubstraitDevEnv310 = mkPoetryEnv final.python310;
ibisSubstraitDevEnv311 = mkPoetryEnv final.python311;

ibisSubstrait38 = mkIbisSubstrait final.python38;
ibisSubstrait39 = mkIbisSubstrait final.python39;
ibisSubstrait310 = mkIbisSubstrait final.python310;
ibisSubstrait311 = mkIbisSubstrait final.python311;
Expand Down
5 changes: 2 additions & 3 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ classifiers = [
]

[tool.poetry.dependencies]
python = ">=3.8.1,<4"
python = ">=3.9,<4"
ibis-framework = ">=3"
packaging = ">=21.3"
pyyaml = ">=5"
Expand Down Expand Up @@ -109,10 +109,9 @@ ignore = [
"SIM114", # combine `if` branches
"SIM117", # nested withs
"SIM118", # remove .keys() calls from dictionaries
# TODO(gil): re-enable after we drop 3.8
"UP006", # use collections.deque instead of Deque for type annotation
]
target-version = "py38"
target-version = "py39"

[tool.ruff.per-file-ignores]
"*test*.py" = ["D"] # ignore all docstring lints in tests
Expand Down

0 comments on commit 023351b

Please sign in to comment.