Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Refetch feed source list when opening project #895

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • e2e tests are all passing (remove this if not merging to master)

Description

Currently we re-fetch the entire feed source list when opening a project, even though we already have all that information downloaded. Really the true fix here is to look at our data insertion pipeline. For now, this PR adds a check that prevents the re-fetch from happening if we already have the needed data.

I would be open to a more holistic solution if anyone has one in mind!

Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a better fix personally, and this seems clean enough especially since it will make a big difference in load times in the short term.

You're on a roll with DT PRs rn (rocket ship emoji)

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm too out of touch with DT right now to consider better approaches, but this works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants