Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support new prefer_s3_links config property #591

Merged
merged 1 commit into from
Mar 19, 2024
Merged

support new prefer_s3_links config property #591

merged 1 commit into from
Mar 19, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Mar 13, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

The new property changes the generated HTML to use s3 urls instead of the auto fetch URLS. All optional, no defaults changed.

@miles-grant-ibigroup miles-grant-ibigroup merged commit ff595d2 into dev Mar 19, 2024
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the support-s3-link-preference branch March 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @amy-corson-ibigroup