You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we have an editor.exec method under the covers that all of the top-level commands call into. This is currently where the dirty path normalization logic occurs, since it can be processed right after a command is run.
And with the withoutNormalizing hook, I think we shouldn't need it. We can instead move dirty path normalization to the end of editor.applyOperation, which seems to make more sense. And then whenever someone needs to apply a series of operations without normalizing, they should be using editor.withoutNormalizing.
This way, we can remove editor.exec and remove the extra layer of indirection that handlers currently call into. Which would mean that when stepping through code you'll jump straight through each method definition instead.
The text was updated successfully, but these errors were encountered:
Do you want to request a feature or report a bug?
Debt / improvement.
What's the current behavior?
Right now we have an
editor.exec
method under the covers that all of the top-level commands call into. This is currently where the dirty path normalization logic occurs, since it can be processed right after a command is run.But #3027 can change this.
And with the
withoutNormalizing
hook, I think we shouldn't need it. We can instead move dirty path normalization to the end ofeditor.applyOperation
, which seems to make more sense. And then whenever someone needs to apply a series of operations without normalizing, they should be usingeditor.withoutNormalizing
.This way, we can remove
editor.exec
and remove the extra layer of indirection that handlers currently call into. Which would mean that when stepping through code you'll jump straight through each method definition instead.The text was updated successfully, but these errors were encountered: