Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing change to atomic annotations throws #2856

Closed
fraziermork opened this issue Jun 6, 2019 · 1 comment
Closed

Undoing change to atomic annotations throws #2856

fraziermork opened this issue Jun 6, 2019 · 1 comment

Comments

@fraziermork
Copy link

Do you want to request a feature or report a bug?

bug

What's the current behavior?

annotation-undo-bug

Not including a jsfiddle because the search highlighting example is sufficient to repro the bug. In the gif, I delete a character in an atomic annotation so that slate cleans it up, then undo that edit. It throws an error somewhere in applyOperation/removeAnnotation.

Not sure if this is related to the whole editor.withoutSaving thing

What's the expected behavior?

not to throw

@ianstormtaylor
Copy link
Owner

As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants