Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox bug: arrow down from void block not moving selection down #2116

Closed
bryanph opened this issue Aug 22, 2018 · 4 comments
Closed

Firefox bug: arrow down from void block not moving selection down #2116

bryanph opened this issue Aug 22, 2018 · 4 comments

Comments

@bryanph
Copy link
Contributor

bryanph commented Aug 22, 2018

Do you want to request a feature or report a bug?

bug

What's the current behavior?

In the image example: arrow down from void block not moving selection down

What's the expected behavior?

the selection moves to the beginning of the next block

@ravi-braj
Copy link

ravi-braj commented Aug 31, 2018

Also having this bug. Arrow down is working from some void block types but not all. See loom video
https://www.useloom.com/share/65144344a6cc4e6e9c62376d59bfab24
Horizontal rule block works fine, but image block does not
For the void block type that isn't working

  • Moving down into a void block works fine, but moving down out of the block isn't working
  • Moving up into the void block isn't working
  • Left and right arrow keys are all working fine

@ericedem
Copy link
Contributor

Just as a data point, disabling this selection workaround lets you navigate down after only two button presses 😅

https://github.com/ianstormtaylor/slate/blob/master/packages/slate-react/src/components/content.js#L230-L236

@skogsmaskin
Copy link
Collaborator

skogsmaskin commented Oct 3, 2018

I think maybe it is related to contentEditable={false} not being respected the same way in Firefox as in i.e. Chrome. I am having issues in Firefox when adding some div inside a node renderer with contentEditable={false}. Chrome will ignore it (as an editable node), while Firefox will not (it still takes cursor and focus). But only at one single position regardless of the text content within that div.

What is also worth noticing is that Firefox also will not respect the CSS property user-select: none on that div's content.

@ianstormtaylor
Copy link
Owner

I believe that this may be fixed by #3093, which has changed a lot of the logic in Slate and slate-react especially. I'm going to close this out, but as always, feel free to open a new issue if it persists for you. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants