Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mapRanges usage smarter #2003

Closed
ianstormtaylor opened this issue Jul 27, 2018 · 2 comments
Closed

make mapRanges usage smarter #2003

ianstormtaylor opened this issue Jul 27, 2018 · 2 comments

Comments

@ianstormtaylor
Copy link
Owner

Do you want to request a feature or report a bug?

Improvement.

What's the expected behavior?

Following from #1993 (comment) it would be nice if the value.mapRanges uses could be made smarter. It should be possible to calculate what the next anchorPath and focusPath should be for all of those updates instead of setting them to null to be re-calculated in Range.normalize by using the key -> path mapping (which can be slow to compute).

@jtadmor
Copy link
Contributor

jtadmor commented Jul 31, 2018

taking a look at this right now.

fwiw, it does look some behavior was broken for selection based on the one test i have added so far (not sure if that has to do with how the test is set-up, possibly not calling Range.normalize in the operations tests).

@ianstormtaylor
Copy link
Owner Author

Moving away from even having this logic exposed, and it can be made more performant as an internal helper in core instead as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants