You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Report a bug, as long as we expect examples to work correct on all supported browsers. Maybe it's not a Slate-related bug, but then we should adjust the example, I think 🙂
recording, with extra commentary typed as console.logs 😛 : http://recordit.co/TA8DUIudTb (please be patient, as the most spectacular crash appears at the end, when I try to type some text)
OS: Apple macOS Sierra 10.12.6 (16G1408)
browser: Firefox Nightly 62.0a1 (2018-06-21) (64-bit) (and same for Firefox Quantum 60.0.2 (64-bit))
moving cursor left/right inside input (below the video) should move the cursor left/right
typing inside input (below the video) should make insert typed character in cursor position
Or, if it is impossible to make proper "embed" example on top of Slate, I expect example to be removed or at least marked somehow to indicate it won't work on Firefox ✌️
The text was updated successfully, but these errors were encountered:
One more thing, which was not included by me in the former message, but probably should be 😛 Which is: I really appreciate Slate.js.
I was doing Proof of Concept of migration to Slate.js (from another tool) in React app of our company. And it was a pleasure to work with Slate 💪 🚀 Sadly, I was unable to make embedded editable input working properly (and we rely heavily on such inputs in current app), so I had to decide we won't migrate.
Hey @nkoder, thanks for the kind words. I think this is actually a duplicate of #1744, so I'm going to close this in favor of that one. Feel free to comment over there with any other info!
Do you want to request a feature or report a bug?
Report a bug, as long as we expect examples to work correct on all supported browsers. Maybe it's not a Slate-related bug, but then we should adjust the example, I think 🙂
What's the current behavior?
Go to "embed" example ( https://www.slatejs.org/#/embeds ). There, inside input below video:
one cannot move cursor left/right
example crashes when trying to type some characters (stacktrace appears in place of rendered editor)
Details:
commit on which I tested that issue is still there in
embed
example: https://github.com/ianstormtaylor/slate/tree/2652680850ae8803afd34f445158f9d6071e2e89/examples/embedsrecording, with extra commentary typed as
console.log
s 😛 : http://recordit.co/TA8DUIudTb (please be patient, as the most spectacular crash appears at the end, when I try to type some text)OS:
Apple macOS Sierra 10.12.6 (16G1408)
browser:
Firefox Nightly 62.0a1 (2018-06-21) (64-bit)
(and same forFirefox Quantum 60.0.2 (64-bit)
)Slate: the one from commit linked above
What's the expected behavior?
As Firefox is supported by Slate ( https://docs.slatejs.org/general/contributing#adding-browser-support ) and I expect examples to work on supported browsers, the expected behaviour is as follows:
moving cursor left/right inside input (below the video) should move the cursor left/right
typing inside input (below the video) should make insert typed character in cursor position
Or, if it is impossible to make proper "embed" example on top of Slate, I expect example to be removed or at least marked somehow to indicate it won't work on Firefox ✌️
The text was updated successfully, but these errors were encountered: