Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Embeds" example is crashing on Firefox when one tries to type into input below the video #1926

Closed
nkoder opened this issue Jun 22, 2018 · 2 comments

Comments

@nkoder
Copy link

nkoder commented Jun 22, 2018

Do you want to request a feature or report a bug?

Report a bug, as long as we expect examples to work correct on all supported browsers. Maybe it's not a Slate-related bug, but then we should adjust the example, I think 🙂

What's the current behavior?

Go to "embed" example ( https://www.slatejs.org/#/embeds ). There, inside input below video:

  • one cannot move cursor left/right

  • example crashes when trying to type some characters (stacktrace appears in place of rendered editor)

Details:

What's the expected behavior?

As Firefox is supported by Slate ( https://docs.slatejs.org/general/contributing#adding-browser-support ) and I expect examples to work on supported browsers, the expected behaviour is as follows:

  • moving cursor left/right inside input (below the video) should move the cursor left/right

  • typing inside input (below the video) should make insert typed character in cursor position

Or, if it is impossible to make proper "embed" example on top of Slate, I expect example to be removed or at least marked somehow to indicate it won't work on Firefox ✌️

@nkoder
Copy link
Author

nkoder commented Jun 25, 2018

One more thing, which was not included by me in the former message, but probably should be 😛 Which is: I really appreciate Slate.js.

I was doing Proof of Concept of migration to Slate.js (from another tool) in React app of our company. And it was a pleasure to work with Slate 💪 🚀 Sadly, I was unable to make embedded editable input working properly (and we rely heavily on such inputs in current app), so I had to decide we won't migrate.

@ianstormtaylor
Copy link
Owner

Hey @nkoder, thanks for the kind words. I think this is actually a duplicate of #1744, so I'm going to close this in favor of that one. Feel free to comment over there with any other info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants