-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix selections with non-void non-editable focus (#5716)
* Fix selections with non-void non-editable focus "Non-void non-editable" refers to `contentEditable={false}` DOM nodes that are rendered by a Slate element render but which are not void elements. For instance, [the checkboxes in the checklists example][1]. [1]: https://github.com/ianstormtaylor/slate/blob/7e77a932f0489a9fff2d8a1957aa2dd9b324aa78/site/examples/check-lists.tsx#L153-L170 * fixup! Fix selections with non-void non-editable focus Optimize leaf node search * fixup! Fix selections with non-void non-editable focus Rename `focusNodeSelectable` to `focusNodeIsSelectable` A more accurate name given this PR's changes. * fixup! Fix selections with non-void non-editable focus Remove inapplicable `if` branch * fixup! Fix selections with non-void non-editable focus Improve comment
- Loading branch information
Showing
4 changed files
with
87 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'slate-react': patch | ||
--- | ||
|
||
Fix selections with non-void non-editable focus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters