New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking file handles #3

Closed

ianlewis opened this issue Aug 19, 2023 · 1 comment · Fixed by #16

Labels

bug

Milestone

Owner

ianlewis commented Aug 19, 2023 •

edited

Loading

From the original bug: denormal#5

It seems this library is leaking file handles here, as I can't find the associated Close call to this os.Open:

https://github.com/denormal/go-gitignore/blob/master/gitignore.go#L146

This is especially problematic on windows where many file operations are blocked if the file is still open.

ianlewis added the bug label

ianlewis mentioned this issue

feat: Add .todosignore file support. ianlewis/todos#135

Draft

Owner Author

ianlewis commented Aug 19, 2023

Tests on windows currently fail because of leaky file handles
https://github.com/ianlewis/go-gitignore/actions/runs/5908593135/job/16028223100

ianlewis mentioned this issue

fix: Close file handles #16

Merged

ianlewis modified the milestones: v1.0.0, v0.1.0

ianlewis closed this as completed in #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment