Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Mismapping of no-return-await to return-await #278

Closed
lotap opened this issue Mar 9, 2022 · 3 comments
Closed

Mismapping of no-return-await to return-await #278

lotap opened this issue Mar 9, 2022 · 3 comments

Comments

@lotap
Copy link
Contributor

lotap commented Mar 9, 2022

The value for no-return-await from airbnb is being incorrectly mapped to return-await (https://typescript-eslint.io/rules/return-await/)

This is effectively linting the opposite of what it should and forcing the code to always add await to the return instead of disallowing it.

Recommend switching to @typescript-eslint/return-await': [baseBestPracticesRules['no-return-await'], 'never'], for parity with the airbnb base config

@iamturns
Copy link
Owner

iamturns commented Mar 9, 2022

Great catch @lotap !

Did you want to create a PR for it? You've done the work and provided the code too, I think you should get the cred!

@lotap
Copy link
Contributor Author

lotap commented Mar 9, 2022

Created #279 lmk if there are any issues, I think this is my first opensource PR

@iamturns
Copy link
Owner

Nice one @lotap ! Released in v16.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants