fix: fix it locale error

[iamkun]

@anbi can you review this pr please?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (dev@97a6088). Click here to learn what that means.
The diff coverage is 100%.

@@         Coverage Diff          @@
##             dev   #458   +/-   ##
====================================
  Coverage       ?   100%           
====================================
  Files          ?     54           
  Lines          ?    473           
  Branches       ?     72           
====================================
  Hits           ?    473           
  Misses         ?      0           
  Partials       ?      0

Impacted Files	Coverage Δ
src/locale/es-do.js	100% <ø> (ø)
src/locale/it.js	100% <ø> (ø)
src/locale/es.js	100% <ø> (ø)
src/locale/es-us.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a6088...2474436. Read the comment docs.

[bi-a]

Done.

[iamkun]

@naulacambra Just updated locale/es.js according to momentjs. Can you review please.
If it's ok, I'll update the test file accordingly.

Plus, after compare to momentjs locale file, there are es.js, es-do.js and es-us.js. But Dayjs has a es-es.js locale file. Is it something wrong?

[naulacambra]

@naulacambra Just updated locale/es.js according to momentjs. Can you review please.
If it's ok, I'll update the test file accordingly.

It's ok 😀

Plus, after compare to momentjs locale file, there are es.js, es-do.js and es-us.js. But Dayjs has a es-es.js locale file. Is it something wrong?

I'll try to explain it correclty. Spanish is spoken worldwildly, but there are some little differences between some regions. es-es is the Spain's spanish (from where am I), es-us United States's spanish, and es-do is the Dominican Republic's spanish. While there are some differences in the vocabulary, the name of months or weekdays, are the same, so for this reason there is no need to have one file for each region.

We should decide which standard we use. Language nomenclature (es for all Spanish regions) or language-region nomenclature (es-es, es-us,...)

[iamkun]

Oh I see.
Not sure if I understood you correctly

It seems es-es is equal to es (Castilian Spanish), and es-us, es-do... has some different.

So that es-es.js is the same with es.js in dayjs, and we should just delete es-es and consider adding es-us, es-do like moment does?

[iamkun]

@naulacambra any suggestions here for my comment above? thanks #458 (comment)

[naulacambra]

@iamkun sorry for the delay.

In this context (dates, week days, etc) es-es, es-us, or es-do are the same. Even they have words with different meaning (they have different words for the same thing), they are the same language and share most of their words.

Regarding your opinion #458 I would delete es-es.js file keeping only the es.js, but I don't believe we'll need to add es-do or es-us files, since they would be the same (check moment localization files, they all are the same)

[iamkun]

@naulacambra thanks.

According to your replay, at present, we should just delete es-es.

And if we add some more cases in locales that might have different between es and es-us, we could add es-do or es-us at that time accordingly.

Right？

[naulacambra]

@iamkun exactly 😀

[iamkun]

Finally I decided to add es-do and es-us.
So that can keep the same with moment, on the other hand, this could also increase our total locale count. 😬

[naulacambra]

So that can keep the same with moment, on the other hand,

Ok, makes sense.

this could also increase our total locale count.

Since they need to be loaded by the user, I don't increase the "default" size, so I think we're fine with that 😀