-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #2428 #2429
Merged
Merged
Fixed issue #2428 #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2429 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 183 183
Lines 2201 2201
Branches 594 593 -1
=========================================
Hits 2201 2201
☔ View full report in Codecov by Sentry. |
Thanks |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
## [1.11.10](v1.11.9...v1.11.10) (2023-09-19) ### Bug Fixes * Add Korean Day of Month with ordinal ([#2395](#2395)) ([dd55ee2](dd55ee2)) * change back fa locale to the Gregorian calendar equivalent ([#2411](#2411)) ([95e9458](95e9458)) * duration plugin - MILLISECONDS_A_MONTH const calculation ([#2362](#2362)) ([f0a0b54](f0a0b54)) * duration plugin getter get result 0 instead of undefined ([#2369](#2369)) ([061aa7e](061aa7e)) * fix isDayjs check logic ([#2383](#2383)) ([5f3f878](5f3f878)) * fix timezone plugin to get correct locale setting ([#2420](#2420)) ([4f45012](4f45012)) * **locale:** add meridiem in `ar` locale ([#2418](#2418)) ([361be5c](361be5c)) * round durations to millisecond precision for ISO string ([#2367](#2367)) ([890a17a](890a17a)) * sub-second precisions need to be rounded at the seconds field to avoid adding floats ([#2377](#2377)) ([a9d7d03](a9d7d03)) * update $x logic to avoid plugin error ([#2429](#2429)) ([2254635](2254635)) * Update Slovenian locale for relative time ([#2396](#2396)) ([5470a15](5470a15)) * update uzbek language translation ([#2327](#2327)) ([0a91056](0a91056))
🎉 This PR is included in version 1.11.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BePo65
pushed a commit
to BePo65/dayjs
that referenced
this pull request
Sep 20, 2023
## [1.11.10](iamkun/dayjs@v1.11.9...v1.11.10) (2023-09-19) ### Bug Fixes * Add Korean Day of Month with ordinal ([iamkun#2395](iamkun#2395)) ([dd55ee2](iamkun@dd55ee2)) * change back fa locale to the Gregorian calendar equivalent ([iamkun#2411](iamkun#2411)) ([95e9458](iamkun@95e9458)) * duration plugin - MILLISECONDS_A_MONTH const calculation ([iamkun#2362](iamkun#2362)) ([f0a0b54](iamkun@f0a0b54)) * duration plugin getter get result 0 instead of undefined ([iamkun#2369](iamkun#2369)) ([061aa7e](iamkun@061aa7e)) * fix isDayjs check logic ([iamkun#2383](iamkun#2383)) ([5f3f878](iamkun@5f3f878)) * fix timezone plugin to get correct locale setting ([iamkun#2420](iamkun#2420)) ([4f45012](iamkun@4f45012)) * **locale:** add meridiem in `ar` locale ([iamkun#2418](iamkun#2418)) ([361be5c](iamkun@361be5c)) * round durations to millisecond precision for ISO string ([iamkun#2367](iamkun#2367)) ([890a17a](iamkun@890a17a)) * sub-second precisions need to be rounded at the seconds field to avoid adding floats ([iamkun#2377](iamkun#2377)) ([a9d7d03](iamkun@a9d7d03)) * update $x logic to avoid plugin error ([iamkun#2429](iamkun#2429)) ([2254635](iamkun@2254635)) * Update Slovenian locale for relative time ([iamkun#2396](iamkun#2396)) ([5470a15](iamkun@5470a15)) * update uzbek language translation ([iamkun#2327](iamkun#2327)) ([0a91056](iamkun@0a91056))
BePo65
pushed a commit
to BePo65/dayjs
that referenced
this pull request
Sep 23, 2023
## [1.11.10](iamkun/dayjs@v1.11.9...v1.11.10) (2023-09-19) ### Bug Fixes * Add Korean Day of Month with ordinal ([iamkun#2395](iamkun#2395)) ([dd55ee2](iamkun@dd55ee2)) * change back fa locale to the Gregorian calendar equivalent ([iamkun#2411](iamkun#2411)) ([95e9458](iamkun@95e9458)) * duration plugin - MILLISECONDS_A_MONTH const calculation ([iamkun#2362](iamkun#2362)) ([f0a0b54](iamkun@f0a0b54)) * duration plugin getter get result 0 instead of undefined ([iamkun#2369](iamkun#2369)) ([061aa7e](iamkun@061aa7e)) * fix isDayjs check logic ([iamkun#2383](iamkun#2383)) ([5f3f878](iamkun@5f3f878)) * fix timezone plugin to get correct locale setting ([iamkun#2420](iamkun#2420)) ([4f45012](iamkun@4f45012)) * **locale:** add meridiem in `ar` locale ([iamkun#2418](iamkun#2418)) ([361be5c](iamkun@361be5c)) * round durations to millisecond precision for ISO string ([iamkun#2367](iamkun#2367)) ([890a17a](iamkun@890a17a)) * sub-second precisions need to be rounded at the seconds field to avoid adding floats ([iamkun#2377](iamkun#2377)) ([a9d7d03](iamkun@a9d7d03)) * update $x logic to avoid plugin error ([iamkun#2429](iamkun#2429)) ([2254635](iamkun@2254635)) * Update Slovenian locale for relative time ([iamkun#2396](iamkun#2396)) ([5470a15](iamkun@5470a15)) * update uzbek language translation ([iamkun#2327](iamkun#2327)) ([0a91056](iamkun@0a91056))
This was referenced May 19, 2024
This was referenced Sep 13, 2024
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.11.10](iamkun/dayjs@v1.11.9...v1.11.10) (2023-09-19) ### Bug Fixes * Add Korean Day of Month with ordinal ([#2395](iamkun/dayjs#2395)) ([dd55ee2](iamkun/dayjs@dd55ee2)) * change back fa locale to the Gregorian calendar equivalent ([#2411](iamkun/dayjs#2411)) ([95e9458](iamkun/dayjs@95e9458)) * duration plugin - MILLISECONDS_A_MONTH const calculation ([#2362](iamkun/dayjs#2362)) ([f0a0b54](iamkun/dayjs@f0a0b54)) * duration plugin getter get result 0 instead of undefined ([#2369](iamkun/dayjs#2369)) ([061aa7e](iamkun/dayjs@061aa7e)) * fix isDayjs check logic ([#2383](iamkun/dayjs#2383)) ([5f3f878](iamkun/dayjs@5f3f878)) * fix timezone plugin to get correct locale setting ([#2420](iamkun/dayjs#2420)) ([4f45012](iamkun/dayjs@4f45012)) * **locale:** add meridiem in `ar` locale ([#2418](iamkun/dayjs#2418)) ([361be5c](iamkun/dayjs@361be5c)) * round durations to millisecond precision for ISO string ([#2367](iamkun/dayjs#2367)) ([890a17a](iamkun/dayjs@890a17a)) * sub-second precisions need to be rounded at the seconds field to avoid adding floats ([#2377](iamkun/dayjs#2377)) ([a9d7d03](iamkun/dayjs@a9d7d03)) * update $x logic to avoid plugin error ([#2429](iamkun/dayjs#2429)) ([2254635](iamkun/dayjs@2254635)) * Update Slovenian locale for relative time ([#2396](iamkun/dayjs#2396)) ([5470a15](iamkun/dayjs@5470a15)) * update uzbek language translation ([#2327](iamkun/dayjs#2327)) ([0a91056](iamkun/dayjs@0a91056))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the initialization of the $x attribute to after the parse method so it won't be affected by other plugins
fix #2428