New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Response#result #85

Open

vinhboy opened this issue Jun 5, 2014 · 1 comment

Collaborator

vinhboy commented Jun 5, 2014

Does anyone find it weird that Response#result

https://github.com/kytrinyx/etsy/blob/master/lib/etsy/response.rb#L52-L60

sometimes return an Array and sometimes a Hash?

I think would be better if it just consistently returns an Array even if count == 1

This is problematic when you are iterating over what you'd expect to be an Array, but then is a Hash.

Collaborator

kytrinyx commented Jun 6, 2014

Yeah, I'd be cool with always making it an array, but it will break backward-compatibility so we'll need to provide a warning on upgrade/install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment