Why does Listing#variations require secure?

[kaoru]

https://github.com/kytrinyx/etsy/blob/master/lib/etsy/listing.rb#L145

def variations(options={})
  options.merge!(:require_secure => true)
  self.class.get_all("/listings/#{id}/variations", oauth.merge(options))
end

Is there any reason for this to have the require_secure parameter set? It seems to work without it.

irb(main):093:0> listing = Etsy::Listing.find('193989447')

irb(main):094:0> listing.variations
RuntimeError: Secure connection required. Please provide your OAuth credentials via :access_token and :access_secret in the parameters

irb(main):109:0> Etsy::Listing.get_all("/listings/#{listing.id}/variations", listing.send(:oauth)).flat_map { |l| l.result.fetch('options').map { |v| v.fetch('value') } }
=> ["A4 (21 x 29.7cm)", "A3 (29.7 x 42cm)"]

Thanks.

[kaoru]

I think this could be related to #107 and #108 ?

[kytrinyx]

@kaoru I'm not sure. For a while listing variations were coming back empty, and I seem to recall that adding oauth to the call caused the variations to come back, but it's been a while and I don't recall the details.

If it now works without it I'd gladly accept a change that removes the secure requirement.

[kaoru]

@kytrinyx cool, I'll see if I can write up a pull request for you 👍

Sadly my Etsy app is "waiting for approval" so until the folks over at Etsy can approve it this is probably going to wallow near the bottom of my priority list 😄

[kytrinyx]

@kaoru Totally understand. Since I no longer have any Etsy apps, this tends to wallow at the bottom of mine as well ❤️