Support for Path objects #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add support for
Pathobjects as compiler inputs.Closes #55
Closes #65
How I did it
Added the
_to_stringprivate function within the wrapper.Pathobjects are converted via.as_posix()- through a lot of experimentation, it seems this is the only way to get consistent path outputs on Windows across all solc versions. Later versions of solc will always convert windows paths to the posix-style, whereas earlier versions simply return it in the same format it's received in.How to verify it
Run tests. This could (and will) be tested better before merging to master.