Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-add-prince7703-131 #131

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BlackPearl7703
Copy link

@BlackPearl7703 BlackPearl7703 commented Oct 14, 2024

Description

Please include a summary of the changes made in this PR. Make sure to explain what changes have been made and why they are necessary.

Checklist

Before submitting your pull request, please ensure you have completed the following tasks:

  • I have read the Contributing Guidelines and followed the process outlined there.
  • I have added tests that prove my fix or feature works as expected (if applicable).
  • I have updated necessary documentation (if applicable).
  • My changes are free from any merge conflicts.
  • I have added my name and PR details to the participants/participants.js file (if contributing in Tier 1 or 2).

PR Title Convention

Please ensure the PR title follows the required format:

For Tier 1 Contribution:

issue-<your-name>-<PR-number>

Example: issue-johndoe-123

For Tier 2 Contribution:

pr-add-<your-name>-<PR-number>

Example: pr-add-johndoe-123

Screenshots (if applicable)

Please include screenshots or videos of your changes (especially if the changes are UI/UX related).

Additional Information

Please provide any additional information that might be helpful for the maintainers or other contributors to understand your changes.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for hacktoberfestgeu ready!

Name Link
🔨 Latest commit 524dd24
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfestgeu/deploys/67101ac5f4df890008524dee
😎 Deploy Preview https://deploy-preview-131--hacktoberfestgeu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BlackPearl7703 BlackPearl7703 changed the title new ui for learn more button issue-prince7703-131 Oct 14, 2024
@BlackPearl7703 BlackPearl7703 changed the title issue-prince7703-131 pr-prince7703-131 Oct 15, 2024
@BlackPearl7703 BlackPearl7703 changed the title pr-prince7703-131 pr-add-prince7703-131 Oct 15, 2024
@vivekrawat21 vivekrawat21 added hacktoberfest This issue is applicable for HacktoberFest-24 hacktoberfest-accepted This PR is accepted for HacktoberFest-24 labels Oct 15, 2024
@iamAyushChamoli
Copy link
Owner

@prince7703 We'll need a darker gradient in the buttons because the current one (IMO) does not sit well with the current color scheme of the website.
Plus, unsure if this is a system issue or an actual bug but the hover effects are very choppy and laggy. Please optimize it anyway because we don't want the website to be choppy on low spec devices.

@BlackPearl7703
Copy link
Author

okay

@iamAyushChamoli
Copy link
Owner

@prince7703 the color scheme is alright now but the hover effects are still choppy. Please optimize them to use less memory/resources.

@BlackPearl7703
Copy link
Author

BlackPearl7703 commented Oct 15, 2024 via email

@iamAyushChamoli
Copy link
Owner

@prince7703 I assume you're not understanding what I am trying to say here. Let me rephrase it; the color scheme and the styles that you used in the previous commit were all good. However, when I hover my cursor on the button, the hover effects are not smooth. They are lagging and slow. You don't have to change the color scheme, you have to update the logic of hover effects to make it smoother. If you are having trouble in that, you can get rid of this hover effect and use a different hover effect altogether.

@BlackPearl7703
Copy link
Author

BlackPearl7703 commented Oct 16, 2024

Behaviour is much more smooth than what it was in prev commit ,, also changed color gradient and tried a new as it looks good with the current background

please check once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is applicable for HacktoberFest-24 hacktoberfest-accepted This PR is accepted for HacktoberFest-24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants