Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Add transcluded scope for inline node templates. Unit tests covering trvw controller as well as transcluded scope feature. #158

Closed
wants to merge 7 commits into from

Conversation

christophercr
Copy link

To continue with the release of v2, new tests are added for the treeview controller (trvw) methods.

@christophercr
Copy link
Author

christophercr commented Sep 12, 2016

Unit tests covering changes in #133

…lates can use functions/variables from such scope (with $parent)
@christophercr christophercr changed the title V2 tests: Add unit tests for treeview controller (trvw) V2: Add transcluded scope for inline node templates. Unit tests covering trvw controller as well as transcluded scope feature. Sep 25, 2016
@christophercr
Copy link
Author

christophercr commented Sep 25, 2016

Solves the issue #81

Hi @jtrussell , could you please have a look on this? I've added the new feature + unit test as well as the missing unit tests for the trvw controller.

@jtrussell
Copy link
Contributor

Merged and published under v2.0.0-alpha.2. Thanks for your efforts :).

@jtrussell jtrussell closed this Sep 27, 2016
@christophercr
Copy link
Author

Hi again, I noticed that this PR was not merged.... I double checked the code and the changes are not there. Probably something went wrong when you merged? Can you please have a look?

@jtrussell
Copy link
Contributor

Sorry, published to npm but forgot to push. Should be there now :).

@christophercr
Copy link
Author

Oh I see... no problem. Thanks! ;)

On Sep 28, 2016 23:28, "Justin Russell" [email protected] wrote:

Sorry, published to npm but forgot to push. Should be there now :).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#158 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFbzDnScPmXOfsApKeBxe7z76m9YlhYxks5qutwPgaJpZM4J7Gcp
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants