-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2: Add transcluded scope for inline node templates. Unit tests covering trvw controller as well as transcluded scope feature. #158
Conversation
Not sure if we'll get around to fixing this particular isue any time soon so calling it out as known.
[ci skip]
Merge latest changes
Unit tests covering changes in #133 |
…lates can use functions/variables from such scope (with $parent)
Solves the issue #81 Hi @jtrussell , could you please have a look on this? I've added the new feature + unit test as well as the missing unit tests for the trvw controller. |
Merged and published under v2.0.0-alpha.2. Thanks for your efforts :). |
Hi again, I noticed that this PR was not merged.... I double checked the code and the changes are not there. Probably something went wrong when you merged? Can you please have a look? |
Sorry, published to npm but forgot to push. Should be there now :). |
Oh I see... no problem. Thanks! ;) On Sep 28, 2016 23:28, "Justin Russell" [email protected] wrote:
|
To continue with the release of v2, new tests are added for the treeview controller (trvw) methods.