Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom views to uhabits-core #1076

Open
8 tasks
iSoron opened this issue Aug 21, 2021 · 0 comments
Open
8 tasks

Move custom views to uhabits-core #1076

iSoron opened this issue Aug 21, 2021 · 0 comments
Labels
refactoring Improvements to the code that don't add new functionality
Milestone

Comments

@iSoron
Copy link
Owner

iSoron commented Aug 21, 2021

Description

To make Loop Habit Tracker available on iOS and the web, we need to be able to render custom views in multiple platforms. Currently, we already have a multiplatform canvas implementation in org.isoron.platform.gui.Canvas (in uhabits-core). While a few custom views are already using this multiplatform implementation (including BarChart and HistoryChart), most of our custom views still use android.graphics directly.

This task is to migrate all remaining custom views to our multiplatform canvas, and remove all direct references to android.graphics.

Notes

  1. We already have some partial implementations (not currently used) in org.isoron.uhabits.core.ui.views, including CheckmarkButton, NumberButton and Ring. These implementations need to be finished.

Subtasks

  • activities/common/views/FrequencyChart.kt
  • activities/common/views/RingView.kt
  • activities/common/views/ScoreChart.kt
  • activities/common/views/StreakChart.kt
  • activities/common/views/TargetChart.kt
  • activities/habits/list/views/CheckmarkButtonView.kt
  • activities/habits/list/views/HeaderView.kt
  • activities/habits/list/views/NumberButtonView.kt
@iSoron iSoron added the refactoring Improvements to the code that don't add new functionality label Aug 21, 2021
@iSoron iSoron added this to the Loop 3.0 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improvements to the code that don't add new functionality
Projects
None yet
Development

No branches or pull requests

1 participant