Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Compass Calibration programmable operation #9411

Merged
merged 6 commits into from
Dec 31, 2023

Conversation

sdellava
Copy link
Contributor

This pull request create the programmable operation n. 52

This operation trigger the Compass Calibration procedure.

This operation, activated by an AUX channel, allow the pilot to trigger the compass calibration process in air.

This option eventually solves the issue of calibrating the mag before take off, that in case of presence of large metal masses or if done close to active electronic devices, can result wrong.

Added activation of the compass calibration request
Added LOGIC_CONDITION_RESET_MAG_CALIBRATION operation
@DzikuVx
Copy link
Member

DzikuVx commented Oct 26, 2023

@sdellava would would need a Configurator update as well

@sdellava
Copy link
Contributor Author

@sdellava would would need a Configurator update as well

Yes, I'll submit a second PR asap

@sdellava
Copy link
Contributor Author

Momentary closed to execute additional tests.

@sdellava sdellava closed this Oct 26, 2023
@shota3527
Copy link
Contributor

It is safe to calibrate compass in air?

@sdellava
Copy link
Contributor Author

Yes it is. I've tested it just one hour ago. But I've find an issue: the calibration process end with a "save setting" procedure that can't be executed while the ARMING_FLAG is TRUE.

The reason is that the function that save the configuration reset the rx link. Therefore it is correct that it can't be execute while armed.

The effect of this issue is that the system message "SAVING SETTING" remain in the OSD until the FC is ARMING_FLAG is turned to FALSE. Then the save setting procedure complete correctly (in the bottom of the post flight data the "SETTING SAVED" message appears.

Anyway, on air calibration processe should not be done in a middle of a flight generic, but in a specific calibration flight, and executed only once in a place. So at the moment I'll do no other modifications related to this new feature.

@sdellava
Copy link
Contributor Author

added related configurator PR iNavFlight/inav-configurator#1854

@sdellava
Copy link
Contributor Author

Temporary closed to solve the conflict

@sdellava sdellava closed this Oct 27, 2023
changed LOGIC_CONDITION_RESET_MAG_CALIBRATION to 53 so solve a conflict with an other PR
@sdellava
Copy link
Contributor Author

sdellava commented Oct 27, 2023

Conflict solved

@sdellava sdellava reopened this Oct 27, 2023
@sdellava
Copy link
Contributor Author

Video of the test here: https://youtu.be/1muitwEfxic

@sdellava
Copy link
Contributor Author

@DzikuVx and team... will this PR will merged or I need to change something?

@DzikuVx DzikuVx modified the milestones: 7.1, 8.0 Dec 30, 2023
Copy link
Member

@DzikuVx DzikuVx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing has to be fixed here, but that also means iNavFlight/inav-configurator#1854 has to be updated

src/main/programming/logic_condition.h Outdated Show resolved Hide resolved
@sdellava
Copy link
Contributor Author

Logic condition changed to 54. configurator updated too.

@DzikuVx DzikuVx merged commit a90203c into iNavFlight:master Dec 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants