-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Compass Calibration programmable operation #9411
Conversation
Added activation of the compass calibration request
Added LOGIC_CONDITION_RESET_MAG_CALIBRATION operation
@sdellava would would need a Configurator update as well |
Yes, I'll submit a second PR asap |
Momentary closed to execute additional tests. |
It is safe to calibrate compass in air? |
Yes it is. I've tested it just one hour ago. But I've find an issue: the calibration process end with a "save setting" procedure that can't be executed while the ARMING_FLAG is TRUE. The reason is that the function that save the configuration reset the rx link. Therefore it is correct that it can't be execute while armed. The effect of this issue is that the system message "SAVING SETTING" remain in the OSD until the FC is ARMING_FLAG is turned to FALSE. Then the save setting procedure complete correctly (in the bottom of the post flight data the "SETTING SAVED" message appears. Anyway, on air calibration processe should not be done in a middle of a flight generic, but in a specific calibration flight, and executed only once in a place. So at the moment I'll do no other modifications related to this new feature. |
added related configurator PR iNavFlight/inav-configurator#1854 |
Temporary closed to solve the conflict |
changed LOGIC_CONDITION_RESET_MAG_CALIBRATION to 53 so solve a conflict with an other PR
Conflict solved |
Video of the test here: https://youtu.be/1muitwEfxic |
@DzikuVx and team... will this PR will merged or I need to change something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing has to be fixed here, but that also means iNavFlight/inav-configurator#1854 has to be updated
Logic condition changed to 54. configurator updated too. |
This pull request create the programmable operation n. 52
This operation trigger the Compass Calibration procedure.
This operation, activated by an AUX channel, allow the pilot to trigger the compass calibration process in air.
This option eventually solves the issue of calibrating the mag before take off, that in case of presence of large metal masses or if done close to active electronic devices, can result wrong.