-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiggle to wake launch idle #8511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added options for detection for different type/size planes - Changed trigger to only use the yaw axis gyro data. - Time limit for individual wiggle to prevent accidental triggers - Time limit for double wiggle, again to prevent accidental triggers.
@b14ckyy has tested on a larger aircraft, and it is working as expected. |
as this was dev build tested with multiple craft sizes and good defaults found I think its time to get merged when conflicts resolved. @DzikuVx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternate, or additional method to start the autolaunch idle throttle. Using this you can wiggle the yaw of the plane to start the idle throttle. This does not start the launch procedure or launch throttle, only idle.
There is one setting in the CLI:
nav_fw_launch_wiggle_to_wake_idle
. 0 = disabled. 1 and 2 signify 1 or 2 yaw wiggles to activate. 1 wiggle has a higher detection point, for airplanes without a tail. 2 wiggles has a lower detection point, but requires the repeated action. This is intended for larger models and airplanes with tails.For this to work, an idle throttle value greater than 1000 must be set, and
nav_fw_launch_wiggle_to_wake_idle
must not be0
. If there is no idle delay, the wiggle will activate the idle throttle. If an idle delay is also set up, whichever occurs first activates the idle throttle.I have tested this on a couple of planes, and it works as intended. But it would be nice to get some tests performed on other planes. Particularly larger models.