-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch parameters with battery capacity unit #10389
Switch parameters with battery capacity unit #10389
Conversation
There is a parameter for the OSD called `osd_stats_energy_unit`. This selects whether mAh or Wh are displayed on the end of flight stats screen. People are confused the when the switch the battery capacity unit to Wh from Ah, this value doesn't change. This PR will change `osd_stats_energy_unit` to match the battery capacity unit if it changes. This will be more an expected behavior. Plus it gives pilots the option to change to the other units for the stats if they want.
This appears to be causing a lockup on disarm on some configurations. Happens on a couple of planes with F4 boards, but not on a multirotor with an F7 board, could be the board or airframe type ?. It's caused by the cli.c change. With that change included it locks up immediately when you disarm, doesn't when your remove it. |
Thanks @breadoven. I came across the issue at the weekend. Thanks for finding the cause. I hadn't had time to investigate. I'll work on a fix. |
Seems it's caused by Have to admit I completely discounted this change as the culprit when I was checking the master merge changes to find the cause. A pain to diagnose when it locks up completely. |
@breadoven yes, the issue is when |
You're right, setting |
Fixed in #10413 |
There is a parameter for the OSD called
osd_stats_energy_unit
. This selects whether mAh or Wh are displayed on the end of flight stats screen. People are confused the when the switch the battery capacity unit to Wh from Ah, this value doesn't change.This PR will change
osd_stats_energy_unit
to match the battery capacity unit if it changes. This will be more an expected behavior. Plus it gives pilots the option to change to the other units for the stats if they want.