From 05d42caa59d15f96d02e538bd1978e3b51644817 Mon Sep 17 00:00:00 2001 From: Mattia Giuffrida Date: Fri, 30 Aug 2024 11:49:48 +0100 Subject: [PATCH] Move dev dependencies to Gemfile and use `main` factory_bot to address activesupport incompatibility --- Gemfile | 6 ++++++ sidekiq-logstash.gemspec | 5 ----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 7f4f5e9..cec8f93 100644 --- a/Gemfile +++ b/Gemfile @@ -3,3 +3,9 @@ source 'https://rubygems.org' gemspec + +gem 'factory_bot', github: 'thoughtbot/factory_bot', branch: 'main' +gem 'rake' +gem 'rspec' +gem 'rspec-json_expectations' +gem 'rubocop-performance' diff --git a/sidekiq-logstash.gemspec b/sidekiq-logstash.gemspec index 77e9d2b..aca7d1f 100644 --- a/sidekiq-logstash.gemspec +++ b/sidekiq-logstash.gemspec @@ -24,10 +24,5 @@ Gem::Specification.new do |spec| spec.add_dependency 'logstash-event', '~> 1.2' spec.add_dependency 'sidekiq', '~> 7.0' - spec.add_development_dependency 'factory_bot', '~> 6.1' - spec.add_development_dependency 'rake', '>= 10' - spec.add_development_dependency 'rspec', '~> 3.0' - spec.add_development_dependency 'rspec-json_expectations', '~> 2.1.0' - spec.add_development_dependency 'rubocop-performance', '~> 1.5' spec.metadata['rubygems_mfa_required'] = 'true' end