Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Stdheprdr and stdheprdrnew ambiguity #8

Open
jstrube opened this issue Feb 4, 2017 · 7 comments
Open

Resolve Stdheprdr and stdheprdrnew ambiguity #8

jstrube opened this issue Feb 4, 2017 · 7 comments

Comments

@jstrube
Copy link

jstrube commented Feb 4, 2017

Maybe it's just me, but I am confused by the fact that there are two implementations of an stdhep reader.
Are both really needed? If so, can one be renamed?

@jstrube jstrube changed the title Resolve Stdheprdr and stdheprdrnew Resolve Stdheprdr and stdheprdrnew ambiguity Feb 4, 2017
@gaede
Copy link
Contributor

gaede commented Apr 11, 2017

Jeremy has fixed an issue in Stdheprdr for the HPS in StdheprdrNew. As we are confident StdhepRdr worked for ILC and CLIC so far, I suggested to add the new one until we find the time to verify that the new one also works for LC. Volunteers for checking this are welcome ...

@JeremyMcCormick
Copy link

JeremyMcCormick commented May 15, 2017

The issue was that the existing "old" reader only uses one set of the parent/daughter links for each HEPEVT record and ignores the other. This is obviously not correct in terms of the HEPEVT standard. Certain StdHep files are processed completely incorrectly by the old reader.

Frank, I really think that as the original author of this reader class, or at least its current maintainer, you need to deal with trying to fix this up and verifying it including testing various StdHep files. The current implementation is simply incomplete, and I don't think that a call for "volunteers" is really going to be adequate. I did my own tests but you are going to need to jump in here and perform your own checks/tests or this is never going to get resolved.

If you need some sample files please let me know.

@jstrube
Copy link
Author

jstrube commented May 16, 2017

@JeremyMcCormick Yes, please point us to some sample files.

@JeremyMcCormick
Copy link

JeremyMcCormick commented May 16, 2017

Hi, Jan.

I may only have available stdhep files for fixed target experiments, rather than full ILC events, which I will try to post here via ftp when I have a chance.

Basically, any generator that relies on daughter to parent pointers (specified by two fields in the HEPEVT block) while not setting the corresponding parent to daughter links, will not be processed properly.

From what I remember the Madgraph 4 and 5 generators produce files by default in which this is the case.

Again though will try to post some files when I have a chance...

@jstrube
Copy link
Author

jstrube commented May 16, 2017

If you have some files where the new reader works, but the old one breaks, that would be good.
I have plenty of files that I know work with the old reader, so I can compare.

@rete
Copy link
Contributor

rete commented Nov 25, 2019

Poping up some issues from hell. Is it fixed by now ? Should we close it ?

@jstrube
Copy link
Author

jstrube commented Nov 25, 2019

Not fixed. Please pick one of the two implementations as default and remove the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants