-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Stdheprdr and stdheprdrnew ambiguity #8
Comments
Jeremy has fixed an issue in Stdheprdr for the HPS in StdheprdrNew. As we are confident StdhepRdr worked for ILC and CLIC so far, I suggested to add the new one until we find the time to verify that the new one also works for LC. Volunteers for checking this are welcome ... |
The issue was that the existing "old" reader only uses one set of the parent/daughter links for each HEPEVT record and ignores the other. This is obviously not correct in terms of the HEPEVT standard. Certain StdHep files are processed completely incorrectly by the old reader. Frank, I really think that as the original author of this reader class, or at least its current maintainer, you need to deal with trying to fix this up and verifying it including testing various StdHep files. The current implementation is simply incomplete, and I don't think that a call for "volunteers" is really going to be adequate. I did my own tests but you are going to need to jump in here and perform your own checks/tests or this is never going to get resolved. If you need some sample files please let me know. |
@JeremyMcCormick Yes, please point us to some sample files. |
Hi, Jan. I may only have available stdhep files for fixed target experiments, rather than full ILC events, which I will try to post here via ftp when I have a chance. Basically, any generator that relies on daughter to parent pointers (specified by two fields in the HEPEVT block) while not setting the corresponding parent to daughter links, will not be processed properly. From what I remember the Madgraph 4 and 5 generators produce files by default in which this is the case. Again though will try to post some files when I have a chance... |
If you have some files where the new reader works, but the old one breaks, that would be good. |
Poping up some issues from hell. Is it fixed by now ? Should we close it ? |
Not fixed. Please pick one of the two implementations as default and remove the other one. |
Maybe it's just me, but I am confused by the fact that there are two implementations of an stdhep reader.
Are both really needed? If so, can one be renamed?
The text was updated successfully, but these errors were encountered: