Filenames include query string making them invalid

[jeppe-smith]

I have an issue with the filenames containing an appended query string (eg. src/views/UsersIndex.vue?vue&type=template&lang.js) in the instrumentation. This causes our CI to fail when it tries to upload our coverage.

After looking around I changed transform method to the following to get rid of the query string.

if (exclude.shouldInstrument(id)) {
  // Remove querys strings from file names.
  const filename = id.replace(/\?.+$/, '')
  const sourceMap = sanitizeSourceMap(this.getCombinedSourcemap());
  const code = instrumenter.instrumentSync(srcCode, filename, sourceMap);
  const map = instrumenter.lastSourceMap();

  // Required to cast to correct mapping value
  return { code, map } as TransformResult;
}

[iFaxity]

Hi @jeppe-smith, great finding!

I will create a pull request with this change and run some tests to see if it works in my setup aswell.

[iFaxity]

There appears to be an official way to get the file name from the reference id. As Vite uses Rollups plugin system in the background, it shares some of it's API: this.getFilename. I will try this and see if it gets the desired results.

[iFaxity]

This will be fixed when the PR #27 gets merged. I'll hopefully do some testing during the weekend.

[github-actions]

🎉 This issue has been resolved in version 2.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀