Linux input fixes #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 10, 2019 17:55
* Use SDL_PollEvent instead of manually checking each event * Remove some newly-unused variables
|
At first glance the fix seems OK, will test it later today. |
|
There was some inconsistency within the file (it was a mix of tabs and
spaces in places) so I wasn't sure which to use. Either that or vim went on
the fritz while I was making changes.
Let me know what you think about the functionality when you're able and
I'll try to get the tabs converted over to spaces before I head to work.
Configuring my controls without this was quite a task. Lol.
…On Fri, Mar 15, 2019, 4:24 AM Stelios Tsampas ***@***.***> wrote:
At first glance the fix seems OK, will test it later today.
On the other hand, the spacing fixes seem odd, the code uses spaces for
indentation and I don't see any reason for them to be replaced with tabs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACvJZSjWAAieqMc4tN7z85HctVY1Xj5mks5vW2bYgaJpZM4bnk7s>
.
|
|
While trying to figure out haptic problems I'm having, I've noticed that this patch breaks building against SDL1: |
|
I don't have a joystick with haptic feedback at the moment, but I'll take a peek at the old API and see if I can't get it building for you again at least. |
|
Actually, it turned out SDL1 is no better than SDL2 (for haptic). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I made these changes I would have to close and re-open the configuration window each time after setting a single joystick key due to it copying my previous input every time I selected the "change" button.
This cleans up the code a little bit and makes it work somewhat better. The only lingering issue that I've come across is it has a little trouble with trigger axises (this was also present before the change).