Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle "Broken Channel" messages #213

Closed
mikedm139 opened this issue Jan 4, 2014 · 4 comments
Closed

Properly handle "Broken Channel" messages #213

mikedm139 opened this issue Jan 4, 2014 · 4 comments
Assignees

Comments

@mikedm139
Copy link

Basically when initially loading a channel (in this case /video/stufftv) if the MediaContainer contains a header string it should be showing the end-user a dialog box with the contents of it. We use this for known broken channels so that users are notified when a pre-installed channel is now known to be broken. We're pinging all of the client devs about this one that don't already have it implemented.
Here's some example XML:

<MediaContainer title1="Stuff.tv" art="http://resources-cdn.plexapp.com/image/art/com.plexapp.plugins.stufftv.jpg?h=9fc2307" viewmode="65586" contenttype="items" header="Stuff.tv may be experiencing problems" message="This channel is currently broken." size="3" identifier="com.plexapp.plugins.stufftv" mediaTagPrefix="/system/bundle/media/flags/" mediaTagVersion="1365387741" searchesKey="/system/services/searches?identifier=com.plexapp.plugins.stufftv">
<Directory thumb="http://resources-cdn.plexapp.com/image/source/com.plexapp.plugins.stufftv.jpg?h=29c22ad" key="/video/stufftv/videocasts" title="VidCasts"/>
<Directory thumb="http://resources-cdn.plexapp.com/image/source/com.plexapp.plugins.stufftv.jpg?h=29c22ad" key="/video/stufftv/reviews" title="Video Reviews"/>
<Directory thumb="/:/plugins/com.plexapp.plugins.stufftv/resources/Search.png?t=1388217997" prompt="Please enter the topic you would like to search..." key="/:/plugins/com.plexapp.plugins.stufftv/serviceSearch?identifier=com.plexapp.plugins.stufftv&name=Stuff%20TV" title="Search" search="1"/>
</MediaContainer>

If possible, the dialog presented to the user with header as the dialog box title, and message as the content.

@iBaa
Copy link
Owner

iBaa commented Jan 5, 2014

Ok, there are more similar features (messages, pop-up menus and stuff) to be implemented.
In this cue... when the "warning" was displayed, should we go on and display the stuff nevertheless?

@Gerk
Copy link

Gerk commented Jan 5, 2014

I would say yes, still go on to display whatever the channel gives you (otherwise devs and/or hackers wouldn't be able to text/fix broken stuff).

@Gerk
Copy link

Gerk commented Jan 5, 2014

That is how other clients handle it.

@moodyblue
Copy link
Collaborator

Don't know if this is already implemented. But it's too late to do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants