From a2a207583dbd581f521fa9e09b9a59dbb8f74139 Mon Sep 17 00:00:00 2001
From: Isaac Hinman <isaac@isaachinman.com>
Date: Wed, 24 Jul 2019 18:13:23 +0100
Subject: [PATCH] fix: Do not call router events in SSR (#419)

---
 __tests__/hocs/app-with-translation.test.js | 73 +++++++++++++++++++++
 src/hocs/app-with-translation.js            | 14 ++--
 2 files changed, 81 insertions(+), 6 deletions(-)
 create mode 100644 __tests__/hocs/app-with-translation.test.js

diff --git a/__tests__/hocs/app-with-translation.test.js b/__tests__/hocs/app-with-translation.test.js
new file mode 100644
index 00000000..d52673ba
--- /dev/null
+++ b/__tests__/hocs/app-with-translation.test.js
@@ -0,0 +1,73 @@
+/* eslint-env jest */
+import React from 'react'
+
+import i18next from 'i18next'
+import { mount } from 'enzyme'
+import NextApp, { Container } from 'next/app'
+
+import { appWithTranslation } from '../../src/hocs'
+import { localeSubpathOptions } from '../../src/config/default-config'
+
+const mockRouterFn = jest.fn()
+
+const defaultConfig = {
+  localeSubpaths: localeSubpathOptions.NONE,
+  allLanguages: ['en'],
+  lng: 'en',
+  react: {
+    wait: true,
+    useSuspense: false,
+  },
+}
+const defaultProps = {
+  Component: () => (
+    <div>Test Page</div>
+  ),
+  router: {
+    replace: mockRouterFn,
+    pathname: '/test-path',
+  },
+}
+
+const createApp = async (config = defaultConfig, props = defaultProps) => {
+  const i18n = i18next.createInstance(config)
+  await i18n.init()
+
+  const appWithTranslationAndContext = appWithTranslation.bind({
+    config,
+    i18n,
+  })
+  const App = appWithTranslationAndContext(class MyApp extends NextApp {
+    render() {
+      const { Component, pageProps } = this.props
+      return (
+        <Container>
+          <Component {...pageProps} />
+        </Container>
+      )
+    }
+  })
+
+  return {
+    i18n,
+    tree: mount(<App {...props} />),
+  }
+}
+
+describe('appWithTranslation', () => {
+  beforeEach(mockRouterFn.mockReset)
+
+  it('will call router events in a browser context', async () => {
+    const { i18n } = await createApp()
+    process.browser = true
+    await i18n.changeLanguage('en')
+    expect(mockRouterFn).toHaveBeenCalledTimes(1)
+  })
+
+  it('will not call router events in a server context', async () => {
+    const { i18n } = await createApp()
+    process.browser = false
+    await i18n.changeLanguage('en')
+    expect(mockRouterFn).toHaveBeenCalledTimes(0)
+  })
+})
diff --git a/src/hocs/app-with-translation.js b/src/hocs/app-with-translation.js
index f999b106..7cd487a7 100644
--- a/src/hocs/app-with-translation.js
+++ b/src/hocs/app-with-translation.js
@@ -29,13 +29,15 @@ export default function (WrappedComponent) {
         const { pathname, asPath, query } = router
         const routeInfo = { pathname, query }
 
-        if (process.browser && config.localeSubpaths !== localeSubpathOptions.NONE) {
-          const { as, href } = lngPathCorrector(config, { as: asPath, href: routeInfo }, lng)
-          if (as !== asPath) {
-            router.replace(href, as)
+        if (process.browser) {
+          if (config.localeSubpaths !== localeSubpathOptions.NONE) {
+            const { as, href } = lngPathCorrector(config, { as: asPath, href: routeInfo }, lng)
+            if (as !== asPath) {
+              router.replace(href, as)
+            }
+          } else {
+            router.replace({ pathname, query })
           }
-        } else {
-          router.replace({ pathname, query })
         }
       })