Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/removing molecules corrupts molecule aware parameters #78

Open
sverhoeven opened this issue May 30, 2022 · 0 comments
Open

Adding/removing molecules corrupts molecule aware parameters #78

sverhoeven opened this issue May 30, 2022 · 0 comments

Comments

@sverhoeven
Copy link
Member

A molecule aware parameter has its schema adjusted so it has the same length as the number of uploaded molecules.
However if you have filled the parameter and remove or add a molecule the data of the molecule aware paramter can become invalid and the user is unable to resolve the validation errors.

Spawned from PR review:

* If I start with one molecule, add flexref settings, then go back and add another molecule, there is no extra array item for seg/fle so I cannot modify settings for the second molecule.
* If I remove a molecule, and try to modify flexref for the remaining one, I get .flexibility.seg should NOT have more than 1 items, but I cannot remove old items because the second table is no longer rendered.

Integration tests in https://github.com/i-VRESSE/workflow-builder/blob/8587a879a18d47a5a68374206be4bc80ca7d5d2f/integration-tests/molecules.spec.ts exercise the problems found in the PR review. The commented out assertions should be enabled to get failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant