Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake install target #4956

Closed
theoparis opened this issue Mar 4, 2024 · 5 comments · Fixed by #5667
Closed

Add cmake install target #4956

theoparis opened this issue Mar 4, 2024 · 5 comments · Fixed by #5667
Labels
enhancement New feature or request

Comments

@theoparis
Copy link
Contributor

theoparis commented Mar 4, 2024

Description

Currently it seems like the makefile is used for the install target even though ninja is used via cmake in the makefile.
I think it would make more sense to add a cmake install target so that you can do this:

cmake -B build -G Ninja
cmake --build build
sudo cmake --install build

This would also benefit the use case of customizing cmake features such as -DNO_XWAYLAND=ON or -DCMAKE_BUILD_TYPE=MinSizeRel without having to modify the makefile. This also impacts setting custom compilers and/or compiler flags.

@theoparis theoparis added the enhancement New feature or request label Mar 4, 2024
@vaxerski
Copy link
Member

vaxerski commented Mar 4, 2024

the problem is install isn't that easy, as we for example use cpio which I don't think cmake has an equivalent.

@cnt0
Copy link
Contributor

cnt0 commented Apr 9, 2024

I guess this is about the installheaders. @vaxerski what you're trying to do with cpio? Keep symlinks? I'm pretty sure cmake has such options in at least some commands, might take a look

@vaxerski
Copy link
Member

vaxerski commented Apr 9, 2024

feel free to MR

@fufexan
Copy link
Member

fufexan commented Apr 10, 2024

I've worked on porting most of the stuff from the Makefile to CMake, and it works fine, except in the Nix build, where CMake seems to build Hyprland twice for some reason. https://github.com/hyprwm/Hyprland/tree/cmake

@fufexan
Copy link
Member

fufexan commented Apr 21, 2024

#5667 please test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants