-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake install target #4956
Comments
the problem is install isn't that easy, as we for example use |
I guess this is about the installheaders. @vaxerski what you're trying to do with cpio? Keep symlinks? I'm pretty sure cmake has such options in at least some commands, might take a look |
feel free to MR |
I've worked on porting most of the stuff from the Makefile to CMake, and it works fine, except in the Nix build, where CMake seems to build Hyprland twice for some reason. https://github.com/hyprwm/Hyprland/tree/cmake |
#5667 please test this. |
Description
Currently it seems like the makefile is used for the install target even though ninja is used via cmake in the makefile.
I think it would make more sense to add a cmake install target so that you can do this:
This would also benefit the use case of customizing cmake features such as
-DNO_XWAYLAND=ON
or-DCMAKE_BUILD_TYPE=MinSizeRel
without having to modify the makefile. This also impacts setting custom compilers and/or compiler flags.The text was updated successfully, but these errors were encountered: