Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocklist is replaced with new data #37

Closed
fauno opened this issue Feb 1, 2024 · 7 comments
Closed

Blocklist is replaced with new data #37

fauno opened this issue Feb 1, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@fauno
Copy link
Collaborator

fauno commented Feb 1, 2024

I'm testing the blocklist API client and I can get the current list and send new items, but when I get the list again, the new items completely replaced the previous list. I assumed they were appended instead:

image

@fauno fauno added the question Further information is requested label Feb 1, 2024
@RangerMauve
Copy link
Contributor

Yeah this sounds like a bug, we should be appending not replacing

@RangerMauve RangerMauve added bug Something isn't working and removed question Further information is requested labels Feb 1, 2024
@fauno
Copy link
Collaborator Author

fauno commented Feb 1, 2024

Thanks! Meanwhile, we have a working {block,allow}list API client for Ruby :D

@RangerMauve
Copy link
Contributor

Oh. It might be due to the syntax not being correct. Each entry should be in @[email protected] syntax with the username being replaceable with * like @*@domain.com.

We should be throwing an error when the syntax is wrong.

@fauno
Copy link
Collaborator Author

fauno commented Feb 9, 2024

I'll check later then :)

@RangerMauve
Copy link
Contributor

is this still an issue?

@fauno
Copy link
Collaborator Author

fauno commented Feb 21, 2024

"Later" hasn't arrived yet, but I'm getting there :P

@fauno
Copy link
Collaborator Author

fauno commented Feb 29, 2024

I confirm this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants