Service exits if exception during authentication. #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a situation where a dbus client would lose connection to the
EmbeddedDBusDaemon
when coming out of hibernate. This happened on OS X, but presumably it's a possibility on other operating systems too.For reference, here is the trace we got.
The SASL chat was somehow getting corrupted, resulting in a failure in the accept loop on the server.
This PR now throws an exception if the SASL command is not valid. Also
AuthenticationException
is now caught higher up and the connection is also closed. This allows the loop to continue and accept more connections.