From 7395896b513377a164b25e6b19c30187d8a534d7 Mon Sep 17 00:00:00 2001
From: Dan Molik <dan@danmolik.com>
Date: Wed, 27 Nov 2024 18:21:41 -0500
Subject: [PATCH] bug(storage): Fix label assignment in PVCs

---
 internal/controller/valkey_controller.go | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/internal/controller/valkey_controller.go b/internal/controller/valkey_controller.go
index d3e9ef2..e2e2a01 100644
--- a/internal/controller/valkey_controller.go
+++ b/internal/controller/valkey_controller.go
@@ -1730,8 +1730,12 @@ func generatePVC(valkey *hyperv1.Valkey) corev1.PersistentVolumeClaim {
 	if valkey.Spec.Storage != nil {
 		pv = *valkey.Spec.Storage
 		pv.ObjectMeta.Name = "valkey-data"
-		for k, v := range labels(valkey) {
-			pv.ObjectMeta.Labels[k] = v
+		if pv.ObjectMeta.Labels == nil {
+			pv.ObjectMeta.Labels = labels(valkey)
+		} else {
+			for k, v := range labels(valkey) {
+				pv.ObjectMeta.Labels[k] = v
+			}
 		}
 	}
 	return pv