Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose badger's CompressionLevel option in Bulk loader #4439

Closed
jarifibrahim opened this issue Dec 18, 2019 · 4 comments · Fixed by #4669
Closed

Expose badger's CompressionLevel option in Bulk loader #4439

jarifibrahim opened this issue Dec 18, 2019 · 4 comments · Fixed by #4669
Assignees
@jarifibrahim
Labels
area/bulk-loader Issues related to bulk loading. area/compression Related to compression of values, keys, and messages. kind/enhancement Something could be better. status/accepted We accept to investigate/work on it.

Comments

@jarifibrahim
Copy link
Contributor

Copied over from hypermodeinc/badger#1163

Badger supports configuring zstd compression level via options which has a huge impact on performance. Right now there is no way for the user to specify the compression level. It would be nice to have a way to set the compression level in bulk loader (maybe a flag?).

It would also make sense to expose the compression algorithm option.
@jarifibrahim jarifibrahim mentioned this issue Dec 18, 2019
Closed
@jarifibrahim jarifibrahim added area/bulk-loader Issues related to bulk loading. area/compression Related to compression of values, keys, and messages. kind/enhancement Something could be better. labels Dec 18, 2019
@xiangzhao632
Copy link

@jarifibrahim Could you explain what benifits we can get from compression? disk space or query latency?
I haved read the blog about BadgerV2.0.0 which didn't talk about the benifits of compression。

@jarifibrahim
Copy link
Contributor Author

The compression reduces the disk space.

@jarifibrahim
Copy link
Contributor Author

@mangalaman93 @harshil-goel ^^

@jarifibrahim jarifibrahim added the status/accepted We accept to investigate/work on it. label Jan 13, 2020
@jarifibrahim jarifibrahim mentioned this issue Mar 31, 2020
Merged
@jarifibrahim jarifibrahim self-assigned this Mar 31, 2020
@jarifibrahim
Copy link
Contributor Author

This has been fixed via #4669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarifibrahim jarifibrahim

Labels
area/bulk-loader Issues related to bulk loading. area/compression Related to compression of values, keys, and messages. kind/enhancement Something could be better. status/accepted We accept to investigate/work on it.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Badger Compression Level option in Bulk Loader hypermodeinc/dgraph
2 participants
@jarifibrahim @xiangzhao632