Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has(predicate) query at root level sometimes leaks nodes that do _not_ have the predicate #2371

Closed
billylindeman opened this issue May 4, 2018 · 6 comments
Labels
kind/bug Something is broken.

Comments

@billylindeman
Copy link

billylindeman commented May 4, 2018

If you suspect this could be a bug, follow the template.

  • What version of Dgraph are you using?
Dgraph version   : v1.0.5
Commit SHA-1     : 82787414
Commit timestamp : 2018-04-20 15:50:53 +1000
Branch           : HEAD

For Dgraph official documentation, visit https://docs.dgraph.io.
For discussions about Dgraph     , visit https://discuss.dgraph.io.
To say hi to the community       , visit https://dgraph.slack.com.

Licensed under Apache 2.0 + Commons Clause. Copyright 2015-2018 Dgraph Labs, Inc.```

  • Have you tried reproducing the issue with latest release?
    yes

  • Steps to reproduce the issue (command/config used to run Dgraph).
    Intermittently a has() query at root level will return nodes that do not have the predicate in it.

In the following screenshot, I have a query that should return all nodes with has(type.company), but sometimes will return nodes of a different type.

This seems to happen after a long running query of that other type. I'd suspect it has something to do with the caching layer?

screen shot 2018-05-03 at 6 46 42 pm

@billylindeman billylindeman changed the title has(predicate) query at root level sometimes leaks nodes that does _not_ have the predicate has(predicate) query at root level sometimes leaks nodes that do _not_ have the predicate May 4, 2018
@sboorlagadda
Copy link
Contributor

is it not consistent and does happen sometimes?

@billylindeman
Copy link
Author

Unfortunately it is not consistently reproducible . It seems that shutting down / starting the dgraph server node fixes it when it starts happening.

@manishrjain manishrjain added the investigate Requires further investigation label May 11, 2018
@billylindeman
Copy link
Author

Pinging on this @sboorlagadda @manishrjain
Any insight into what is happening?

@manishrjain
Copy link
Contributor

Sorry, haven't had a chance to look at this yet. If you have steps that we could take to reproduce this problem, they'd help.

@billylindeman
Copy link
Author

@manishrjain this happens on our dataset only with has(predicate) queries, and only after dgraph has been running for a long time. If I reboot the dgraph server it does not happen. I can't really provide reproduction steps more than that, but that should give some indication of where to look? It must be a caching issue of some sort?

@manishrjain manishrjain added kind/bug Something is broken. and removed investigate Requires further investigation labels Jul 16, 2018
@manishrjain
Copy link
Contributor

This should be fixed by #2585.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken.
Development

No branches or pull requests

3 participants