From 50ddf21298ea141ec97809e5258d4c8c9bbf32ba Mon Sep 17 00:00:00 2001 From: Martin Martinez Rivera Date: Mon, 30 Sep 2019 10:10:22 -0700 Subject: [PATCH] Fix ineffassign warnings. (#1055) --- key_registry_test.go | 2 +- value_test.go | 2 +- y/y_test.go | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/key_registry_test.go b/key_registry_test.go index 5315ca6c5..4924d7b5d 100644 --- a/key_registry_test.go +++ b/key_registry_test.go @@ -112,7 +112,7 @@ func TestMismatch(t *testing.T) { _, err = rand.Read(encryptionKey) require.NoError(t, err) opt.EncryptionKey = encryptionKey - kr, err = OpenKeyRegistry(opt) + _, err = OpenKeyRegistry(opt) require.Error(t, err) require.EqualError(t, err, ErrEncryptionKeyMismatch.Error()) } diff --git a/value_test.go b/value_test.go index 0e7abdf85..2e549ab94 100644 --- a/value_test.go +++ b/value_test.go @@ -671,7 +671,7 @@ func TestReadOnlyOpenWithPartialAppendToValueLog(t *testing.T) { opts.ReadOnly = true // Badger should fail a read-only open with values to replay - kv, err = Open(opts) + _, err = Open(opts) require.Error(t, err) require.Regexp(t, "Database was not properly closed, cannot open read-only|Read-only mode is not supported on Windows", err.Error()) } diff --git a/y/y_test.go b/y/y_test.go index f128c64cc..168da889b 100644 --- a/y/y_test.go +++ b/y/y_test.go @@ -222,10 +222,12 @@ func TestPagebufferReader3(t *testing.T) { // Read EOF. n, err = reader.Read(readBuf) require.Equal(t, err, io.EOF, "should return EOF") + require.Equal(t, n, 0) // Read EOF again. n, err = reader.Read(readBuf) require.Equal(t, err, io.EOF, "should return EOF") + require.Equal(t, n, 0) } // Test when read buffer is larger than PageBuffer. @@ -250,4 +252,5 @@ func TestPagebufferReader4(t *testing.T) { // Read EOF. n, err = reader.Read(readBuf) require.Equal(t, err, io.EOF, "should return EOF") + require.Equal(t, n, 0) }