Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Improve Generated documentation #65

Merged
merged 8 commits into from
Jun 21, 2023

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Jun 20, 2023

Description

Adding typedoc to generate documentation for interfaces and most components for us automatically, we just are required to document with standard jsdoc comments the implementations. Types are documented by default.

Also took the freedom to hide some classes in favour of the future cryptograhic abstraction, so I'm not exposing secp, ed, etc.

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for this 🙌 ❤️

.github/workflows/release-docs.yml Outdated Show resolved Hide resolved
.github/workflows/release-docs.yml Show resolved Hide resolved
@elribonazo elribonazo merged commit db3c20e into master Jun 21, 2023
atala-dev added a commit that referenced this pull request Jun 22, 2023
## [2.0.2](v2.0.1...v2.0.2) (2023-06-22)

### Bug Fixes

* **docs:** Correct the required commands to run the nodejs + browser … ([#64](#64)) ([fec65fe](fec65fe))
* **docs:** Improve Generated documentation ([#65](#65)) ([db3c20e](db3c20e))
* Documentation improvements ([#62](#62)) ([6d43d03](6d43d03))
github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
## [2.0.2](v2.0.1...v2.0.2) (2023-06-22)

### Bug Fixes

* **docs:** Correct the required commands to run the nodejs + browser … ([#64](#64)) ([fec65fe](fec65fe))
* **docs:** Improve Generated documentation ([#65](#65)) ([db3c20e](db3c20e))
* Documentation improvements ([#62](#62)) ([6d43d03](6d43d03))
@elribonazo elribonazo deleted the feature/docs-sdk-reference branch May 2, 2024 09:14
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
## [2.0.2](hyperledger-identus/sdk-ts@v2.0.1...v2.0.2) (2023-06-22)

### Bug Fixes

* **docs:** Correct the required commands to run the nodejs + browser … ([hyperledger-identus#64](hyperledger-identus#64)) ([fec65fe](hyperledger-identus@fec65fe))
* **docs:** Improve Generated documentation ([hyperledger-identus#65](hyperledger-identus#65)) ([db3c20e](hyperledger-identus@db3c20e))
* Documentation improvements ([hyperledger-identus#62](hyperledger-identus#62)) ([6d43d03](hyperledger-identus@6d43d03))

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants