Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update e2e env vars #122

Merged
merged 3 commits into from
Nov 22, 2023
Merged

test: update e2e env vars #122

merged 3 commits into from
Nov 22, 2023

Conversation

amagyar-iohk
Copy link
Contributor

Description

Jira link

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

Copy link

github-actions bot commented Nov 10, 2023

Lines Statements Branches Functions
Coverage: 37%
36.75% (1636/4451) 25.8% (714/2767) 39% (495/1269)

JUnit

Tests Skipped Failures Errors Time
209 2 💤 0 ❌ 0 🔥 55.698s ⏱️

@amagyar-iohk amagyar-iohk changed the title test: updates e2e environment variables test: update e2e env vars and change to pull_request_target Nov 10, 2023
@amagyar-iohk amagyar-iohk marked this pull request as ready for review November 13, 2023 11:49
Copy link
Contributor

@antonbaliasnikov antonbaliasnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've discussed, pull_request_target is not secure, so, we're not merging this.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@amagyar-iohk amagyar-iohk changed the title test: update e2e env vars and change to pull_request_target test: update e2e env vars Nov 21, 2023
@amagyar-iohk amagyar-iohk merged commit 47c2c2f into master Nov 22, 2023
@amagyar-iohk amagyar-iohk deleted the test/update-env-vars branch November 22, 2023 12:23
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants