Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implementing Startable and propagating stop() #309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat!: implementing Startable and propagating stop() #309

wants to merge 2 commits into from

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Oct 22, 2024 •
edited
Loading

Description:

Issue: #225

Agent.stop() now chains into Pluto.stop() which chains to Store.stop().

  • Created Startable namespace to define and share implementation.
  • Pluto interface extends Startable.IController
  • Pluto/rxdb/Store added stop() fn
  • Pluto implementation extends Startable.Controller
  • Pollux implementation extends Startable.Controller
  • Agents
    • replaced duplicated AgentState with Startable.State
    • handled start and stop
  • added functional tests

BREAKING CHANGES:

  • Pluto interface now extends Startable.IController
    • start signature changes to return Promise<Startable.State>
    • stop is now required

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h requested a review from a team as a code owner October 22, 2024 12:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Lines Statements Branches Functions
Coverage: 76%
 76.66% (3670/4787) 66.97% (1687/2519) 80.99% (878/1084)

@coveralls
Copy link

coveralls commented Oct 22, 2024 •
edited
Loading

Coverage Status

coverage: 73.117% (+0.5%) from 72.596%
when pulling bb6c013 on feature/225-startables
into 4f7974d on main.

@curtis-h curtis-h force-pushed the feature/225-startables branch from aaa05f7 to df79399 Compare October 22, 2024 12:27
@curtis-h curtis-h mentioned this pull request Oct 22, 2024
Open
@curtis-h curtis-h changed the title feat: implementing Startable and propogating stop() feat: implementing Startable and propagating stop() Oct 22, 2024
@elribonazo elribonazo linked an issue Oct 22, 2024 that may be closed by this pull request
Agent.stop doesn't close store #225
Open
@curtis-h curtis-h force-pushed the feature/225-startables branch from df79399 to 10bfe51 Compare October 31, 2024 09:07
@coveloper
Copy link

Can this be merged?

@elribonazo
Copy link
Contributor

After rebase @curtis-h we waited enough time, I would propose to merge yeah!

@curtis-h curtis-h force-pushed the feature/225-startables branch from 10bfe51 to 97fa0bd Compare January 2, 2025 16:32
@curtis-h curtis-h changed the title feat: implementing Startable and propagating stop() feat!: implementing Startable and propagating stop() Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent.stop doesn't close store
4 participants
@curtis-h @coveralls @coveloper @elribonazo