Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address did:peer:2 spec changes #108

Closed
FabioPinheiro opened this issue Nov 17, 2023 · 8 comments · Fixed by #140
Closed

Address did:peer:2 spec changes #108

FabioPinheiro opened this issue Nov 17, 2023 · 8 comments · Fixed by #140
Labels
enhancement New feature or request

Comments

@FabioPinheiro
Copy link

FabioPinheiro commented Nov 17, 2023

Is this a regression?

No

Description

Address the changes on the did:peer specs made by this PR

The work of how to fix the libraries and applications to address those changes can be found here, and is also is been tracked.

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

No response

Anything else?

No response

@FabioPinheiro
Copy link
Author

@hamada147 can you fix this?

@FabioPinheiro
Copy link
Author

Is on fixed on the input-output-hk/atala-prism-didcomm-kmm#14
Do we need to update the lib here?

@mkbreuningIOHK
Copy link
Contributor

@cristianIOHK and @hamada147 , are you working on it since last week I think, right?

@mkbreuningIOHK mkbreuningIOHK added the enhancement New feature or request label Feb 26, 2024
@mkbreuningIOHK
Copy link
Contributor

@cristianIOHK , is this not completed with the release v3.0.0?

@hamada147
Copy link
Contributor

@mkbreuningIOHK this issue has been fixed a very long time ago. The changes requested here has been added in the DIDComm Repo and we are using the latest version of that repo inside our Wallet SDK KMM

@cristianIOHK
Copy link
Contributor

With that being said, I will close this issue as it was resolved bug forgotten here.

@mkbreuningIOHK
Copy link
Contributor

Thanks @cristianIOHK @hamada147 : And is there a PR or a release that can be linked to this issue so we have traceability?

@hamada147
Copy link
Contributor

@mkbreuningIOHK this is the PR #140

@hamada147 hamada147 mentioned this issue Apr 29, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants