Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prism-agent): add keycloak authorization support to endpoints #753

Merged
merged 34 commits into from
Oct 16, 2023
Merged

feat(prism-agent): add keycloak authorization support to endpoints #753

merged 34 commits into from
Oct 16, 2023

Conversation

patlo-iog
Copy link
Contributor

@patlo-iog patlo-iog commented Oct 11, 2023 •
edited
Loading

Overview

ATL-5822. Support JWT authorization using keycloak.

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@patlo-iog patlo-iog force-pushed the feat/mt-keycloak-auth-integration branch from 35ec694 to 495f618 Compare October 11, 2023 17:46
@patlo-iog patlo-iog changed the title feat(prism-agent): add keycloak authorization support to endpoints [WIP feat(prism-agent): add keycloak authorization support to endpoints [WIP] Oct 11, 2023
@patlo-iog patlo-iog requested a review from mineme0110 October 11, 2023 17:49
@patlo-iog patlo-iog force-pushed the feat/mt-keycloak-auth-integration branch from 105891d to 5dec1bd Compare October 11, 2023 17:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Atala PRISM Test Results

  79 files  ±0    79 suites  ±0   15m 37s ⏱️ -8s
680 tests +1  669 ✔️ +1  11 💤 ±0  0 ❌ ±0 
686 runs  +1  675 ✔️ +1  11 💤 ±0  0 ❌ ±0 

Results for commit 589565e. ± Comparison against base commit 9a8e216.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
io.iohk.atala.agent.server.AgentInitializationSpec ‑ AgentInitialization - validateAppConfig - fail when both apikey and default wallet are disabled

io.iohk.atala.agent.server.AgentInitializationSpec ‑ AgentInitialization - validateAppConfig - do not fail the default wallet is disabled, but any authentication is enabled
io.iohk.atala.agent.server.AgentInitializationSpec ‑ AgentInitialization - validateAppConfig - fail when the default wallet is disabled and authentication is set to apiKey but disabled

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Integration Test Results

11 files  ±0  11 suites  ±0   3s ⏱️ -1s
25 tests ±0  25 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
37 runs  ±0  37 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 589565e. ± Comparison against base commit 9a8e216.

♻️ This comment has been updated with latest results.

yshyn-iohk
yshyn-iohk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

Pat Losoponkul added 16 commits October 16, 2023 10:57
feat(prism-agent): support keycloak auth config
1149123 
Signed-off-by: Pat Losoponkul <[email protected]>
feat(prism-agent): update auth config validation
13f96a4 
Signed-off-by: Pat Losoponkul <[email protected]>
chore: remove unused classes
52b9693 
Signed-off-by: Pat Losoponkul <[email protected]>
revert: change config file back
786b099 
Signed-off-by: Pat Losoponkul <[email protected]>
feat(prism-agent): add keycloak auth placeholder interface
4549676 
Signed-off-by: Pat Losoponkul <[email protected]>
Revert "chore: remove unused classes"
2c8e543 
This reverts commit 2a619194b46b03da2eeaa087cae49f6244f59ae1.

Signed-off-by: Pat Losoponkul <[email protected]>
Revert "Revert "chore: remove unused classes""
1846d85 
This reverts commit 2f45ee639075b874ff270e61578a111222fd0568.

Signed-off-by: Pat Losoponkul <[email protected]>
fix(prism-agent): make tests compile
bbabf8c 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: mulitple auth poc on tapir endpoint
4a02cca 
Signed-off-by: Pat Losoponkul <[email protected]>
feat(prism-agent): apply jwt auth for did-registrar endpoints
0d5e25f 
Signed-off-by: Pat Losoponkul <[email protected]>
wip: keycloak authz permissions check poc
68eafd6 
Signed-off-by: Pat Losoponkul <[email protected]>
build: create new user in keycloak init script
f330ba7 
Signed-off-by: Pat Losoponkul <[email protected]>
feat(prism-agent): implement RPT permission logic
0256bed 
Signed-off-by: Pat Losoponkul <[email protected]>
feat(prism-agent): support batch wallet get
d455a6a 
Signed-off-by: Pat Losoponkul <[email protected]>
chore: resolve merge conflicts
e65f1ad 
Signed-off-by: Pat Losoponkul <[email protected]>
feat(prism-agent): authz interface
cd54202 
Signed-off-by: Pat Losoponkul <[email protected]>
Pat Losoponkul added 16 commits October 16, 2023 10:57
feat(prism-agent): add keycloak client wrapper
12f7e57 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: token introspection
e0c604f 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate connection endpoints to authz
4f22945 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate event endpoints to authz
f27d795 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate wallet & entity endpoitns to authz
14ccdba 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate isscred endpoints to authz
b611fc5 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate creddef & schemareg endpoints to authz
606ab8f 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate verpolicy endpoints to authz
94f686d 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: migrate presentproof endpoints to authz
9f4b0a2 
Signed-off-by: Pat Losoponkul <[email protected]>
chore: small refactor
1157662 
Signed-off-by: Pat Losoponkul <[email protected]>
build: use official keycloak image
baa0bb1 
Signed-off-by: Pat Losoponkul <[email protected]>
build: create manage client in local keycloak bootstrap
64d44e1 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: make tests compile
696a9ed 
Signed-off-by: Pat Losoponkul <[email protected]>
chore: minor cleanup
29aefc6 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: make keycloak not call service when disabled
f8cc424 
Signed-off-by: Pat Losoponkul <[email protected]>
chore: pr cleanup
992f08b 
Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog force-pushed the feat/mt-keycloak-auth-integration branch from 5dec1bd to 992f08b Compare October 16, 2023 05:26
@patlo-iog patlo-iog changed the title feat(prism-agent): add keycloak authorization support to endpoints [WIP] feat(prism-agent): add keycloak authorization support to endpoints Oct 16, 2023
@patlo-iog patlo-iog marked this pull request as ready for review October 16, 2023 05:38
@patlo-iog patlo-iog requested a review from bvoiturier as a code owner October 16, 2023 05:38
chore: expose app config envs
eaed8c8 
Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog force-pushed the feat/mt-keycloak-auth-integration branch from 2410b8d to eaed8c8 Compare October 16, 2023 11:10
@patlo-iog patlo-iog merged commit 3e7534f into main Oct 16, 2023
10 checks passed
@patlo-iog patlo-iog deleted the feat/mt-keycloak-auth-integration branch October 16, 2023 12:42
atala-dev added a commit that referenced this pull request Oct 24, 2023
@atala-dev
chore(release): cut atala prism 1.18.0 release
e790efe 
# [1.18.0](prism-agent-v1.17.0...prism-agent-v1.18.0) (2023-10-24)

### Bug Fixes

*  all performance tests run succesfully, add group thresholds ([#750](#750)) ([5204838](5204838))

### Features

*  presentation API refactor ([#765](#765)) ([045d829](045d829))
* add new auth params ([#762](#762)) ([b8bfb86](b8bfb86))
* disable cors by default ([#747](#747)) ([1dd8c8b](1dd8c8b))
* migrate docker image of the agent to Java 21 ([#758](#758)) ([d36dbf0](d36dbf0))
* **prism-agent:** add keycloak authorization support to endpoints ([#753](#753)) ([3e7534f](3e7534f))

Signed-off-by: Anton Baliasnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patextreme patextreme patextreme left review comments

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@mineme0110 mineme0110 Awaiting requested review from mineme0110

@bvoiturier bvoiturier Awaiting requested review from bvoiturier

Assignees
No one assigned
Labels
Component: Cloud Agent Component: Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patlo-iog @patextreme @yshyn-iohk @atala-dev