Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofs from presentation request not work #1438

Closed
kieutuan218 opened this issue Nov 14, 2024 · 2 comments
Closed

Proofs from presentation request not work #1438

kieutuan218 opened this issue Nov 14, 2024 · 2 comments
Assignees

Comments

@kieutuan218
Copy link

kieutuan218 commented Nov 14, 2024

Is this a regression?

Yes

Description

Hello, regarding the request body for the presentation request:

I don't understand the fields proofs.schemaId and proofs.trustIssuers. Although I sent a credential that does not match the schemaId and issuerDid, the status in the cloud agent still returns "PresentationVerified."
Is that a bug?

{
    "connectionId": "bee34719-def5-4420-8d4f-35318e72e916",
    "proofs": [
        {
            "schemaId": "ddec9bf9-b187-3862-897d-dd11d1c1eb53",
            "trustIssuers": [
                "did:prism:invalidddddđ"
            ]
        }
    ],
    "options": {
        "challenge": "{{$randomUUID}}",
        "domain": "https://prism-verifier.com"
    },
    "credentialFormat": "JWT"
}

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

1.39.1-104-1c7c38e

Anything else?

No response

@FabioPinheiro
Copy link
Contributor

FabioPinheiro commented Nov 14, 2024

@kieutuan218 thanks for the report. This is probably a bug.
We had this problem before we fix it implemented and it seems that we break it again

@amagyar-iohk can you create to tests so we know when if someone breaks this in the future?

@mineme0110 do you have time to figure out where we are missing the check or why its not going to the correct credential state?

@mineme0110
Copy link
Contributor

This can be closed now
#1453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants