fix: Wallet Management Error Handling #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
requested review from
bvoiturier,
yshyn-iohk,
patlo-iog and
mineme0110
as code owners
CryptoKnightIOG
added
autoupdate
bvoiturier
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
LGMT but it would be good to have @patlo-iog's review as well IMO 💪
| case class PermissionNotAvailable(userId: UUID, cause: String) | ||
| extends PermissionManagementServiceError(StatusCode.BadRequest, cause) | ||
|
|
||
| case class ServiceError(cause: String) extends PermissionManagementServiceError(StatusCode.InternalServerError, cause) |
There was a problem hiding this comment.
It looks like this one represents the catch-all "unexpected error" case, right? From the caller's perspective, there is no way to recover from this type of failure, so I would remove it and throw a defect in the service implementation instead.
| ) | ||
| .asSome | ||
| .catchSome { case e: RuntimeException => | ||
| if (e.getMessage().contains("Could not find resource")) ZIO.none | ||
| if (e.getMessage.contains("Could not find resource")) ZIO.none |
There was a problem hiding this comment.
@patlo-iog Just a side comment, but this looks rather fragile... 🧐
There was a problem hiding this comment.
Indeed. It's a shame library we use don't expose information about resource not found 🥲, but I can recheck.
|
Late to the party, but LGTM |
hyperledger-bot
added a commit
that referenced
this pull request
Jul 15, 2024
# [1.38.0](cloud-agent-v1.37.0...cloud-agent-v1.38.0) (2024-07-15) ### Bug Fixes * Move InMemory classes to the test moduels ([#1240](#1240)) ([823057a](823057a)) * move mocks into the test modules ([#1236](#1236)) ([df83026](df83026)) * use Put and Get for DID in doobie statement ([#1250](#1250)) ([fc1cf51](fc1cf51)) * Wallet Management Error Handling ([#1248](#1248)) ([cfd5101](cfd5101)) ### Features * upgrade docusaurus and semantic-release packages ([de53f1d](de53f1d)) Signed-off-by: Allain Magyar <[email protected]>
shotexa
pushed a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
shotexa
pushed a commit
that referenced
this pull request
Jul 17, 2024
# [1.38.0](cloud-agent-v1.37.0...cloud-agent-v1.38.0) (2024-07-15) ### Bug Fixes * Move InMemory classes to the test moduels ([#1240](#1240)) ([823057a](823057a)) * move mocks into the test modules ([#1236](#1236)) ([df83026](df83026)) * use Put and Get for DID in doobie statement ([#1250](#1250)) ([fc1cf51](fc1cf51)) * Wallet Management Error Handling ([#1248](#1248)) ([cfd5101](cfd5101)) ### Features * upgrade docusaurus and semantic-release packages ([de53f1d](de53f1d)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://input-output.atlassian.net/browse/ATL-6838