Broken Swagger links in documentation #1620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
actions/upload-artifact and actions/download-artifact have been deprecated and need updated. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Fix CVE-2024-45338 and update Postgres
Per the LFDT requirements adding an OpenSSF scorecard workflow Signed-off-by: Enrique Lacal <[email protected]>
Add OpenSSF scorecard
Signed-off-by: Anastasia Lalamentik <[email protected]>
lanasta
force-pushed
the
swagger-path-fix
branch
from
5a9c0f1 to
3d25437
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 337 337
Lines 29504 29504
=======================================
Hits 29492 29492
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
EnriqueL8
approved these changes
Jan 27, 2025
|
Needs Dockerfile fix from #1617 before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updated the Swagger link structure to omit the
swagger.htmlportion and to switch away from using the relative pathe.g. From
https://hyperledger.github.io/firefly/latest/reference/swagger/swagger.html#/Default%20Namespace/postGenerateContractInterfacetohttps://hyperledger.github.io/firefly/latest/swagger/#/Default%20Namespace/postGenerateContractInterfaceFixes #1619
Types of changes
Please make sure to follow these points
< issue name >egAdded links in the documentation.Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.