Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FABN-909] Add new fabric-protos module
In order to move common (between the fabric-client and fabric-ca-client modules) code into the fabric-common module, the protocol buffer definitions must be moved as well. This CR moves the protocol buffer definitions into a new fabric-protos module, that exports all available classes via the same structure that ProtoLoader.load is currently returning. This means that the protocol buffer definitions can only be loaded *once* in a single place; currently they are loaded multiple times in multiple code files. The protocol buffer definitions can easily be updated by running "npm run update" within this module. Today they have to be manually copied from Fabric, and edited to fix up the include paths. Future changes could look at generating static JavaScript code (using protoc), or switching to a newer version of protobufjs - however both of these (I did look!) require substantial code changes to the SDK due to protocol buffer API changes. Change-Id: I7b41106d9afcea72c081f5b23bc2192b8cb86020 Signed-off-by: Simon Stone <[email protected]>
- Loading branch information