Skip to content

Commit

Permalink
[FABC-492] Superfluous checks for deleting identity
Browse files Browse the repository at this point in the history
Redunant authority checks were being made by fabric-ca
server for a identity delete request. Removed the secondary
round of authority checks.

Change-Id: Ia4d1b1433b6b9c7214a6acdd31b035a3a37c10a0
Signed-off-by: Saad Karim <[email protected]>
  • Loading branch information
Saad Karim committed Oct 8, 2018
1 parent 72d2f80 commit 0de6679
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lib/serveridentities.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,6 @@ func processDeleteRequest(ctx *serverRequestContextImpl, caname string) (*api.Id
return nil, err
}

err = ctx.CanManageUser(userToRemove)
if err != nil {
return nil, err
}

_, err = registry.DeleteUser(removeID)
if err != nil {
return nil, caerrors.NewHTTPErr(500, caerrors.ErrRemoveIdentity, "Failed to remove identity: %s", err)
Expand Down

0 comments on commit 0de6679

Please sign in to comment.