Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum: add contractDeployerAddress to context #808

Conversation

benjamincburns
Copy link
Contributor

Without this change, it's impossible to configure Ownable contracts and similar from within the benchmark callback script. This is useful for RBAC contracts as well.

@benjamincburns benjamincburns force-pushed the include_deployer_addr_in_context branch from 6c222a7 to 4d0c15f Compare April 18, 2020 00:58
Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@nklincoln nklincoln merged commit 1121b95 into hyperledger-caliper:master Apr 21, 2020
@nklincoln
Copy link
Contributor

@benjamincburns - thanks for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants